update polling to 3.x - #279
Closed
Fabian-Gruenbichler wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Fabian Grünbichler <git@fabian.gruenbichler.email>
keepsimple1
reviewed
Dec 2, 2024
| &zc.signal_sock, | ||
| polling::Event::readable(SIGNAL_SOCK_EVENT_KEY), | ||
| ) { | ||
| #[allow(unsafe_code)] |
Owner
There was a problem hiding this comment.
Thanks for your PR! I want to keep this library safe code only, unless we really have to break it.
Let me take a look at our options.
Owner
|
As I wanted to keep this lib safe code only, and Could you please confirm if |
Author
|
it is (in unstable/testing, which will become trixie/stable next year :)) |
Owner
|
Thanks for confirming. I've merged PR #280, which replaced this PR. Will close this PR now. If any related questions, please feel free to open a new issue or PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
didn't do any in-depth tests and don't know this code base all to well, so please don't hesitate to do things differently as you see fit.
Debian has recently upgrade to polling 3.x, and this is one of the few packaged crates still using the 2.x release series..