fix(clearsign): chain-scope THORChain router in clear-sign predictor#364
Open
BitHighlander wants to merge 1 commit into
Open
fix(clearsign): chain-scope THORChain router in clear-sign predictor#364BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
…edictor firmwareClearSigns() mirrors the device's native clear-sign allowlist so the REST/WalletConnect signing overlay can predict whether the device will clear-sign (and avoid force-enabling AdvancedMode on a tx it would render natively). It matched THORChain deposits against the Ethereum-mainnet router only, ignoring chainId — so it mispredicted an Avalanche THORChain deposit as blind-sign. Scope the pin to (address, chainId) via THOR_ROUTER_BY_CHAIN, in lockstep with firmware thor_router_for_chain (ethereum_contracts/thortx.c). Adds the live-verified Avalanche router; BSC/Base omitted until verified live, matching the firmware side. Companion to BitHighlander/keepkey-firmware#309.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to BitHighlander/keepkey-firmware#309.
firmwareClearSigns()mirrors the device's native clear-sign allowlist so the REST/WalletConnect signing overlay predicts whether the device will clear-sign (and avoids force-enabling AdvancedMode on a tx the device would render natively). It matched THORChain deposits against the Ethereum-mainnet router only, ignoringchainId, so it mispredicted an Avalanche THORChain deposit.This scopes the pin to
(address, chainId)viaTHOR_ROUTER_BY_CHAIN, in lockstep with firmwarethor_router_for_chain. Adds the live-verified Avalanche router (00dc6100..); BSC/Base omitted until verified live (the shipped host catalog's AVAX router is stale, and those pairs route via Relay today).Note: this is the predictor for the REST/WC overlay, a different flow from the swap path that surfaced the bug — the swap AVAX→ETH clear-sign is fixed by the firmware PR alone. This keeps the two in lockstep.
No firmware submodule pin bump here — that lands separately after #309 merges.