refactor(qr): drop the scan-screen capture feature#355
Merged
Conversation
Removes the native screen-capture QR path (captureScreens RPC, src/bun/screen-capture.ts, and the scan-screen option in QrScannerOverlay). The macOS Screen Recording TCC flow proved too brittle to ship: the grant is keyed to the responsible process (Terminal/IDE in dev, outer bundle in prod) and needs an app relaunch to take effect. Camera and image drop/upload scanning are unchanged for WalletConnect, Send, and Zcash flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the native screen-capture QR path end to end:
captureScreensRPC (schema entry, bun handler,ScreenCaptureResulttype)src/bun/screen-capture.ts(CoreGraphics TCC preflight +screencaptureshelling)QrScannerOverlayCamera scanning and image drop/upload are unchanged for the WalletConnect, Send, and Zcash flows.
Why
The macOS Screen Recording TCC flow proved too brittle to ship: the grant is keyed to the responsible process (Terminal/IDE in dev builds, the outer app bundle in prod), requires an app relaunch to take effect, and the resulting "permission granted but still failing" states read as broken scanning.
Verification
grepclean: no references tocaptureScreens/ScreenCaptureResult/screen-capture/scanScreenremain insrc/