fix(firmware): prompt to confirm on-device during firmware upload#350
Merged
Conversation
Flashing unsigned firmware, the bootloader shows an 'unrecognized firmware, install anyway?' confirm at the UPLOAD stage — but the progress message just said 'Uploading firmware...', so the flash looked stuck with no hint to look at the device (real report: user didn't press confirm, wizard stranded). node-hid readSync blocks the event loop during the button wait (see flash notes), so a button-request event can't reliably fire mid-upload — the message emitted *before* the blocking firmwareUpload is the reliable signal. Reword the upload-stage messages (firmware update, custom flash, bootloader) to tell the user to look at the device and confirm if prompted.
2 tasks
Collaborator
Author
|
Backed out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During live btc-only testing, flashing unsigned firmware stranded the setup wizard: the bootloader's 'unrecognized firmware, install anyway?' confirm appears at the upload stage, but the progress message said only
Uploading firmware...— no hint to look at the device, so it read as a hang.node-hidreadSyncblocks the event loop during the button wait (per the in-code flash notes), so abutton-requestevent can't reliably fire mid-upload. The message emitted before the blockingfirmwareUploadis the reliable signal — reword it (firmware update, custom flash, bootloader paths) to direct the user to the device.