feat(clearsign): vault/SDK identity-icon wiring + signing idle-timeout fix#342
Merged
Merged
Conversation
…t fix
- POST /eth/clearsign/load-signer accepts icon (hex, <=384B) + iconWidth/
iconHeight + persist, forwards them to hdwallet loadClearsignSigner so a
loaded identity's logo reaches the device (firmware 7.15 persistent
identities). SDK LoadClearsignSignerParams + schema grow the fields.
- Bun.serve idleTimeout: 0 — human-gated signing legitimately blocks the
response longer than Bun's 120s default; letting the socket close aborted
the second consecutive sign mid-confirm ('other side closed'). Device
signing has no business timing out at the socket layer.
- test: CLEARSIGN_FLOW=<key> runs a single clear-sign flow (isolates one
flow / sidesteps the consecutive-sign path).
…nto device test
Turns any protocol/identity logo into the KeepKey 1bpp mono-RLE bitmap the
OLED renders (<=384B, <=64x64):
- encode-icon.mjs: image -> mono-RLE, self-verified by round-tripping through
a mirror of the firmware draw_bitmap_mono_rle decoder + 384B cap check.
ImageMagick does resize/center/threshold; this owns only the RLE codec.
- build-catalog.mjs: batch sources/*.{png,svg,jpg} -> generated catalog JSON.
- clearsign-signer-flows.js: loads the generated Pioneer identity logo with
persist=true so the device renders it on the trust screen + every per-tx
confirm (CLEARSIGN_NO_ICON=1 for the text-only path).
Foundation for per-protocol icons: drop a logo in sources/, run build-catalog.
The clearsigner is a third-party provider, not KeepKey — a KeepKey mark would conflate the two and undermine the trust model. Replace the test K glyph with a Pioneer compass rose (48x48, 316B). Test loads it under alias 'Pioneer'.
One handoff per NEW feature/fix (persistent identities, clearsign allowlist, emulator dead-click/capture/confirm-button, idle-timeout, icon tooling, SDK tests, perf telemetry, RUJI icon, rujira failover, emu-ABI graft) + an INDEX with test order, env prereqs, and open items.
…; add fw clearsign-gate test
Collaborator
Author
|
Added two UX commits on top of the identity-icon work:
All frontend-only, typecheck clean vs the develop baseline. Firmware submodule pin intentionally left out (rc7 is cut & CI-green on the fork). |
This was referenced Jul 12, 2026
BitHighlander
force-pushed
the
feat/clearsign-identity-icons-vault
branch
from
299a21d to
1640b14
Compare
…dle-timeout, icon coupling, docs - encode-icon: cap literal packets at 127 (128 emits control 0x80/-128 which overflows firmware int8 count and trips draw.c assertion). +boundary self-test. - rest-api: drop server-wide idleTimeout:0; disable idle timeout per-request only for signing + clear-sign trust routes via server.timeout(req, 0). - schemas: refine LoadClearsignSignerRequest so icon/iconWidth/iconHeight are all-present-or-all-absent; SDK type documents the coupling. - docs: SDK loadClearsignSigner notes persist/icon; handoff #53 marked MERGED; drop stray </content> in INDEX.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault/SDK half of the persistent clear-sign identity feature. Scope trimmed — the swap and Hive commits that were bundled here moved to #345 and #346; this PR is now clearsign-only.
POST /eth/clearsign/load-signeracceptsicon(hex ≤384B) +iconWidth/iconHeight+persist, forwards to hdwalletloadClearsignSignerso a loaded identity's logo reaches the device. SDKLoadClearsignSignerParams+ zod schema grow the fields.Bun.serve idleTimeout: 0— human-gated signing legitimately blocks the response past Bun's idle timeout; letting the socket close aborted the second consecutive sign mid-confirm (other side closed). Device signing shouldn't time out at the socket layer.scripts/clearsign-icons/; Pioneer compass identity icon.firmware-clearsign-gate.test.ts— pure unit test locking thefirmwareClearSignsallowlist to the device's native clear-sign set.Dependencies (both MERGED)
modules/hdwalleteccc3fa6(keepkey.tsdestructuresicon/iconWidth/iconHeight/persist).Test plan