release: v1.4.11 — Hyperliquid EIP-712 colon-namespaced typed-data signing fix#329
Merged
Conversation
chore: merge back v1.4.10 version bump into develop
…12 signing Re-pins modules/hdwallet to 2a24030b (keepkey/hdwallet#51), which fixes a crash signing any EIP-712 typed data whose primaryType contains a colon (e.g. Hyperliquid's "HyperliquidTransaction:ApproveAgent" and its ~11 sibling action types). Previously surfaced to users as a generic "Failed to sign typed ETH message".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix release v1.4.11 — release notes.
Single fix, re-pins
modules/hdwalletto the merged keepkey/hdwallet#51:primaryTypenames (e.g. Hyperliquid'sHyperliquidTransaction:ApproveAgentand its ~11 sibling action types). Previously crashed with a generic "Failed to sign typed ETH message" — root cause was theeip-712struct-hashing dependency truncating type names at the first non-word character.Merge-back to
developalready done (commit0904a14e).Verification
v1.4.10..release/1.4.11— confirmed the only non-submodule change is the version bump, and the only submodule change is the hdwallet pin