7.15 (3/5): Device robustness — BIP-85, BIP-39 recovery validation, fault-injection hardening#446
Open
BitHighlander wants to merge 11 commits into
Open
Conversation
Catch a mistyped word on entry instead of producing a silently wrong seed.
Signature-index bytes in flash metadata are attacker-writable, so their presence must not stand in for cryptographic verification. Call the fault-injection-hardened signatures_ok() again before deciding flash_collectHWEntropy() and bootloader compatibility checks.
… prev-word label - B4: finalize guard fails on any non-auto-completed word regardless of enforce_wordlist; the flipped guard let the default (host-omitted) path store a mistyped/garbage phrase as the seed and report success - B5: recovery_delete_character resyncs the current-word accumulators (decoded_word from mnemonic, coded_word via reverse cipher) so a backspace-corrected word validates on its real value instead of stale bytes — stale bytes wrongly aborted and storage_reset a real recovery - B6: the previous-word indicator is snapshotted at the word boundary (auto-expanded) instead of on every keystroke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3/5 of the 7.15 stack. Stacks on 2/5 (
release/7.15.0-pr2-new-chains).Independent device-robustness work — no chain or clear-signing dependencies.
-Werrorand cppcheck.Same base pins as 1/5. Builds green.