Skip to content

fix(nodehid): use async read() so device Cancel can dispatch #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 1 commit into from
Jul 13, 2026
Merged

fix(nodehid): use async read() so device Cancel can dispatch #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/hdwallet-keepkey-nodehid/src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,14 @@ export class TransportDelegate implements keepkey.TransportDelegate {

async readChunk(): Promise<Uint8Array> {
if (!(await this.isOpened())) throw new Error("cannot read from a closed connection");
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const result = await this.hidRef!.readSync();
// node-hid's async read() runs on a background thread, unlike readSync() which
// blocks the JS event loop for the entire time the device waits for a button
// press — that freeze prevented the concurrent cancelDeviceSigning RPC from ever
// dispatching, so an on-device Cancel (e.g. from the swap flow) could never fire.
const result = await new Promise<number[]>((resolve, reject) => {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
this.hidRef!.read((err, data) => (err ? reject(err) : resolve(data)));
});
return new Uint8Array(result);
}

Expand Down
Loading