feat(eth): add LoadClearsignSigner (msg 117) to KeepKey hdwallet#52
Merged
Conversation
Wires the runtime EVM clear-sign signer load (RAM-only, device-confirmed) into the transport layer so the Vault REST layer can expose it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the runtime EVM clear-sign signer load (RAM-only, device-confirmed) into the transport layer so the Vault REST layer can expose
POST /eth/clearsign/load-signer.packages/hdwallet-keepkey/src/ethereum.ts— hand-written jspbLoadClearsignSignermessage (msg 117: key_id, pubkey, alias) +ethLoadClearsignSigner(). device-protocol fork doesn't have msg 117 as a real .proto yet, so this mirrors the existing msg 115/116 (EthereumTxMetadata/Ack) hand-written pattern.packages/hdwallet-keepkey/src/keepkey.ts—KeepKeyHDWallet.loadClearsignSigner()public method.Requires firmware 7.15.0+ (LoadClearsignSigner support). Part of the vault clear-sign train (keepkey/keepkey-vault PR incoming).
Test plan
tests/evm-clearsign/clearsign-signer-flows.js(self mode) — pending a vault build with this pointer