fix(nodewebusb): drop legacy PID 0x0001 from WebUSB getDevice filter#49
Draft
BitHighlander wants to merge 1 commit into
Draft
fix(nodewebusb): drop legacy PID 0x0001 from WebUSB getDevice filter#49BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
WebUSB can never serve a 0x0001 device — the TransportDelegate ctor rejects any non-0x0002 PID with FirmwareUpdateRequired. Matching 0x0001 in the active pair filter only produced a doomed WebUSB attempt and a misleading 'Firmware 6.1.0 required' error before the caller's HID fallback. Old devices now skip WebUSB cleanly and pair over HID. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users with old (2019-era, PID
0x0001) KeepKeys report failures connecting to update — including a misleading "Firmware 6.1.0 or later is required" path, and confusion around "device connected to another device."Root cause
The WebUSB adapter's
getDevice()filter matched bothWEBUSB_PRODUCT_ID(0x0002) and the legacyHID_PRODUCT_ID(0x0001). But theTransportDelegateconstructor rejects any non-0x0002PID withFirmwareUpdateRequired("KeepKey", "6.1.0"). So WebUSB can never serve a0x0001device — matching it in the active pair filter only produced a doomed WebUSB attempt and a misleading firmware-update error before the caller's HID fallback ran.Fix
Remove
0x0001from thegetDevicerequest filter. Old devices now skip WebUSB cleanly and pair over HID (the transport they actually need).getDevices()(passive enumeration) still lists0x0001for detection, so device-present signaling is unaffected.Notes
0x0002devices.claimInterfacecode-19 →ConflictingApp(real contention), unchanged by this PR.Test plan