feat: protocol additions for the firmware 7.x release (thorchain denom, ripple memo, hive, zcash)#111
Open
BitHighlander wants to merge 2 commits into
Open
Conversation
Adds the device-protocol messages required by the upcoming firmware release:
- thorchain: ThorchainMsgSend.denom (field 11) — non-RUNE assets (TCY, RUJI, IBC)
- ripple: RippleSignTx.memo (field 7) — XRP->THORChain swap routing
- hive: full Hive support — HiveGetPublicKey(s), HiveSignTx,
HiveSignAccountCreate/Update (MessageType 1600-1609)
- zcash: clear-signing + Orchard shielded protocol (transparent in/out/ack,
PCZT, FVK, display-address)
All additions are new optional fields / new message types — additive and
backward-compatible. lib/ bindings are gitignored build artifacts; package.json
build:js/json updated to include messages-hive.proto.
BitHighlander
added a commit
to BitHighlander/keepkey-firmware
that referenced
this pull request
Jun 30, 2026
INTENTIONALLY RED: upstream master lacks the proto field this fix needs (denom/memo land via keepkey/device-protocol#111). This PR is BLOCKED until #111 merges; re-pin to the updated master then → green.
BitHighlander
added a commit
to BitHighlander/keepkey-firmware
that referenced
this pull request
Jun 30, 2026
INTENTIONALLY RED: upstream master lacks the proto field this fix needs (denom/memo land via keepkey/device-protocol#111). This PR is BLOCKED until #111 merges; re-pin to the updated master then → green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A single comprehensive
device-protocolupdate covering the entire upcomingfirmware 7.x release. All changes are additive (new optional fields / new
message types) and backward-compatible — existing clients are unaffected.
Additions
THORChain —
ThorchainMsgSend.denom(field 11)Non-RUNE native assets (TCY, RUJIRA/RUJI, IBC denoms). Optional; does not touch
reserved 10.Ripple —
RippleSignTx.memo(field 7)XRP→THORChain swap routing memo.
Hive — full Hive blockchain support (MessageType 1600–1609)
HiveGetPublicKey(s)/HivePublicKey(s),HiveSignTx/HiveSignedTx,HiveSignAccountCreate/Update/HiveSigned…. SLIP-0048 Graphene signing.Zcash — clear-signing + Orchard shielded protocol
Transparent input/output/ack, PCZT sign flow, Orchard FVK, display-address.
Notes
lib/bindings are gitignored build artifacts (regenerate vianpm run build);package.jsonbuild:js/build:jsonupdated to includemessages-hive.proto.master— not re-added.consumes the regenerated bindings (companion PR).