feat(thorchain): add denom field to ThorchainMsgSend (field 11)#109
Closed
BitHighlander wants to merge 1 commit into
Closed
feat(thorchain): add denom field to ThorchainMsgSend (field 11)#109BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
Collaborator
Author
|
Consolidating into a single comprehensive device-protocol PR covering the entire firmware release (not per-field). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
optional string denom = 11;toThorchainMsgSend.message ThorchainMsgSend { optional uint64 amount = 8 [jstype = JS_STRING]; optional OutputAddressType address_type = 9; reserved 10; + optional string denom = 11; // asset denom, e.g. "rune" or IBC denom }Why
THORChain
MsgSendnow carries non-RUNE native assets — TCY, RUJIRA (RUJI),and IBC-denominated tokens. The device needs the asset denom to display and
sign these correctly; today
ThorchainMsgSendcan only express RUNE.Wire compatibility
reserved 10.denomare unaffected (RUNE-only behavior preserved).Downstream
Consumed by keepkey-firmware (denom charset validation + display) and
python-keepkey test vectors, both staged to pin this commit once merged.