build: invoke protobufjs CLI explicitly in build:json#108
Open
BitHighlander wants to merge 1 commit into
Open
Conversation
Bare 'pbjs' resolves to node_modules/.bin/pbjs -> ../pbjs/cli.js (the unrelated
pbjs@0.0.5 dependency), not protobufjs's CLI, so 'npm run build:json' fails
parsing the protos ('Expected = but found 3'). Invoke node_modules/protobufjs/bin/pbjs
directly. Verified: npm run build now regenerates a valid lib/proto.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm run build(andprepublishOnly) fails atbuild:json:package.jsondeclares bothprotobufjs@^6.8.8and an unrelatedpbjs@^0.0.5. The latter wins thenode_modules/.bin/pbjssymlink (-> ../pbjs/cli.js), so barepbjsinvokes the wrong tool, which can't parse the protos.This is latent until a clean build actually runs — which keepkey-vault now does on every release build (it rebuilds device-protocol's gitignored
lib/from source), so it currently breaks the release pipeline.Fix
Invoke protobufjs's CLI explicitly:
node node_modules/protobufjs/bin/pbjs. One line, no dependency/lockfile change.Test plan
npm run buildregenerates a valid 137KBlib/proto.json(verified locally)Follow-up (not here): the
pbjs@^0.0.5devDependency is dead weight that shadows protobufjs's bin — worth removing.