Skip to content

Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=17.10 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tah0 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix jpg_quality/jpeg_quality field mismatch with OCRmyPDF >=17.10 #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/dpsprep/ocrmypdf_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,18 @@ def run_ocrmypdf_optimizer(options: DpsPrepOptions) -> bool:
quality = options.quality_overrides.get_global_value()
workdir = options.workdir

# Detect the OcrOptions JPEG quality key: was renamed in OCRmyPDF 17.10
jpg_quality_key = 'jpeg_quality' if 'jpeg_quality' in OcrOptions.model_fields else 'jpg_quality'

omp_options = OcrOptions(
input_file=workdir.combined_pdf_without_text_path,
output_file=workdir.combined_pdf_path,
# Jobs correspond to CPU cores rather than threads, but it seems better to use the available pool size parameter
jobs=options.pool_size,
optimize=options.optlevel,
# When set to 0, OCRmyPDF's "optimize" function attempts to adjust them
jpg_quality=quality or 0,
png_quality=quality or 0,
**{jpg_quality_key: quality or 0},
)

info = PdfInfo(workdir.combined_pdf_path)
Expand Down
Loading