Replace ttf_parser, rustybuzz with read-fonts, HarfRust - #151
Merged
Conversation
dhardy
force-pushed
the
push-ktmyxrtnoyon
branch
from
August 25, 2026 06:56
3c17707 to
ddfc5ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111: migrates away from ttf-parser (officially no longer maintained) and rustybuzz (unmaintained) to read-fonts and HarfRust.
This loses support for variations in some font metrics (though not in shaping). Likely this is rarely observable anyway. (It might be when using font variations without the
shapingfeature. Kerning will also be broken in that case. It still may be better for user experience to just let the library output badly spaced glyphs than error out so I won't add a lint.)Note:
read-fontsis clearly a much lower level and less opinionated library thanttf_parser, and is significantly harder to use as a result. It may be more efficient (e.g. this approach lets us read and store only the kerning sub-tables we will use), though I can't tell whether re-constructing tables on-demand is the intended way to use them vs storing the table with its redundant pointer vs extracting all desired data during the initial read (though fns likeHmtx::advanceare clearly not designed for the latter).