Note on work-around for float_conversions feature - #71
Merged
Conversation
dhardy
force-pushed
the
push-ktmnstpntluk
branch
from
August 28, 2026 08:52
6b07f25 to
64d4936
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: recommend
Cast::cast(x)wherex.cast()triggers a warning of conflict withfloat_conversionsfeature.Rationale: this is a minimum-commitment workaround for a conflict with an unstable (and thus uncertain) feature. If the feature lands (especially the additional int→int casts), we should reconsider (e.g. renaming
castor abandoning the library as obsolete — though currently the unstablestdlib additions lack trait methods which renders them an incomplete replacement).