ConvertExact → ConvExact, Convert → ConvTo - #65
Merged
Conversation
Contributor
Author
|
The generic parameters to Edit: this commit was removed from the PR. |
dhardy
force-pushed
the
push-konpquuzvunt
branch
from
August 3, 2026 09:26
8c5d842 to
0ca6499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major change of this PR is to remove the trait
generic::Convert; this was already redundant withConvToso all impls are moved there.Note: the name
ConvTois preferred overConvertfor consistencyAlso changed:
ConvertExact→ConvExact(also adjusted method names) and moved to modtraitsReverse order of generic parameters used byCastTo,ConvTo: theR: Roundingparameter now comes firstFurther note: doc changes here are minimal; more will land later.