rsass-cli: bump version to match library (0.29.3-PRE)#215
Open
dustinkirkland wants to merge 1 commit into
Open
rsass-cli: bump version to match library (0.29.3-PRE)#215dustinkirkland wants to merge 1 commit into
dustinkirkland wants to merge 1 commit into
Conversation
The rsass-cli sub-crate's Cargo.toml has carried a stale version
string ("0.29.1-PRE") through multiple library releases — the root
library Cargo.toml has advanced 0.29.0 -> 0.29.1 -> 0.29.2 -> 0.29.3-PRE
while rsass-cli stayed at 0.29.1-PRE.
The practical impact is that the rsass CLI binary's --version output
no longer reflects the actual release version. Downstream packagers
running version-check tests (e.g. Chainguard's stereo test/tw/ver-check)
see drift: binary reports 0.29.1-PRE while the package was built from
the v0.29.2 (or later) source tag.
Surfaced by reverse-dependency testing at
https://github.com/chainguard-sandbox/rdep-testing — full writeup at
chainguard-dev/stereo#102129.
Long-term fix: consider using workspace-level version inheritance
(`version.workspace = true`) so cli and library can't drift again.
This PR is the minimal pin-bump to unblock the immediate case.
Signed-off-by: Dustin Kirkland <dustin.kirkland@chainguard.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rsass-clisub-crate'sCargo.tomlhas carried a stale version string ("0.29.1-PRE") through multiple library releases — the root libraryCargo.tomlhas advanced0.29.0→0.29.1→0.29.2→0.29.3-PREwhilersass-clistayed at0.29.1-PRE.Bump it to
0.29.3-PREto match.Why it matters
The practical impact is that the
rsassCLI binary's--versionoutput no longer reflects the actual release version. Downstream packagers running version-check tests (e.g. Chainguard's stereotest/tw/ver-check) see drift: the binary reports0.29.1-PREwhile the package was built from thev0.29.2(or later) source tag.How surfaced
Found by Chainguard's reverse-dependency testing of all 8k+ packages in our distribution
Suggested follow-up (optional, not in this PR)
Consider using workspace-level version inheritance to prevent recurrence:
This would let
cliand library version-bump together automatically on each release.This PR is just the minimal pin-bump to unblock the immediate case. Happy to follow up with the workspace-inheritance refactor if you'd like.