kip-290: clarify ABv2 proxy install runs at FORK_BLOCK - 1 finalize#120
Merged
Conversation
"Starting from FORK_BLOCK" is observably correct for transactions executing at block FORK_BLOCK onward, but leaves the install timing ambiguous from the core-client / RPC-state perspective. `eth_getCode(0x400, FORK_BLOCK - 1)` already returns the proxy bytecode because the install hook runs at the finalize state of block FORK_BLOCK - 1 — that 1-block precision matters for operators (pre-deployment deadline is FORK_BLOCK - 1 finalize, not FORK_BLOCK) and for implementers (exact hook location). Add one normative sentence tightening this to MUST language. No semantic change for typical readers.
hyunsooda
requested review from
adnpark,
blukat29,
hyeonLewis and
ian0371
as code owners
ian0371
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ABv2 proxy is installed at
FORK_BLOCK - 1finalize, not atFORK_BLOCK.