Skip to content

feat: draft negative location exclusions#39

Merged
kLOsk merged 1 commit into
kLOsk:mainfrom
thiagoc7:feat/draft-negative-location-exclusions
Jul 10, 2026
Merged

feat: draft negative location exclusions#39
kLOsk merged 1 commit into
kLOsk:mainfrom
thiagoc7:feat/draft-negative-location-exclusions

Conversation

@thiagoc7

Copy link
Copy Markdown

Adds draft support/workflow for negative location exclusions.

@kLOsk

kLOsk commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Thanks, this fills a real gap (#46 tracks it). To land it: (1) rebase onto v0.10.0 (current_config() instead of _config); (2) use entity_type="campaign_criterion" for consistency with the existing rules docs; (3) dedupe against existing exclusions, main already has _existing_negative_geo_exclusions() you can reuse; (4) tests plus a rules-file entry (see PR #38 for the standard). Note that PR #34 contains an overlapping implementation; this one is the better base, so it gets to be the canonical version.

@kLOsk
kLOsk merged commit 1d52377 into kLOsk:main Jul 10, 2026
@kLOsk

kLOsk commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Merged to main — thank you @thiagoc7! 🙏 Clean implementation that slotted straight into the current codebase despite two months of drift (multi-tenant safety refactor landed in between). I added tests for the preview/apply paths and documented the tool in the README + orchestration rules on top of your commit. add_negative_locations ships as the 47th tool in the next release.

kLOsk added a commit that referenced this pull request Jul 10, 2026
…onfig()

PR #39 predated the multi-tenant runtime refactor; its server.py
registration referenced the removed module-level _config global and
merged textually clean, so the tool NameErrored on every call (masked
as an error dict by _safe). Regression guards: a static scan of
server.py for stale _config tokens and a call-through of the tool via
FastMCP with a runtime-bound config.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvgwTbTqEinTJXNriN5ga1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants