Skip to content

Fix preview modulemap and module resolution#40

Merged
k-kohey merged 1 commit into
mainfrom
fix-preview-modulemap-index-paths
Jul 10, 2026
Merged

Fix preview modulemap and module resolution#40
k-kohey merged 1 commit into
mainfrom
fix-preview-modulemap-index-paths

Conversation

@k-kohey

@k-kohey k-kohey commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Include third-party dependency manifest module maps even when they live outside the build
    directory, while still skipping SDK/toolchain module maps.
  • Parse header directives in non-framework module maps to derive include paths.
  • Resolve preview thunk module names from Index Store data and tolerate macOS /tmp and /private/
    tmp path aliases.

Verification

  • go test ./internal/preview/build -count=1
  • go test ./internal/preview/analysis -run 'TestIndexStoreCache|
    TestBuildTransitiveDeps_WithCache' -count=1
  • go test ./internal/preview -run 'TestModuleNameForSource|TestParseTrackedFiles|
    TestCompilePipeline|TestGenerate' -count=1
  • Built local axe binary and generated Preview report successfully for 3 files / 8 previews

@k-kohey k-kohey force-pushed the fix-preview-modulemap-index-paths branch from 7e64d56 to 12fd3c3 Compare July 10, 2026 16:38
@k-kohey k-kohey marked this pull request as ready for review July 10, 2026 17:29
@k-kohey k-kohey merged commit b59ca40 into main Jul 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant