Migrate repository package versioning to Central Package Management and updated versions#555
Migrate repository package versioning to Central Package Management and updated versions#555Copilot wants to merge 15 commits into
Conversation
Agent-Logs-Url: https://github.com/jwt-dotnet/jwt/sessions/541ca410-e034-4c5e-8b7e-bf82c0c1aa33 Co-authored-by: abatishchev <351644+abatishchev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jwt-dotnet/jwt/sessions/e91c4aab-1454-4504-9485-fe8dbc99c18b Co-authored-by: abatishchev <351644+abatishchev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jwt-dotnet/jwt/sessions/d0426489-6804-4aac-9fa6-90db8fa805ca Co-authored-by: abatishchev <351644+abatishchev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jwt-dotnet/jwt/sessions/42c54a3f-e3ed-4538-9171-7ff2d9bd1f59 Co-authored-by: abatishchev <351644+abatishchev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jwt-dotnet/jwt/sessions/15b2593e-4f44-43e9-be18-4b6144eee1e5 Co-authored-by: abatishchev <351644+abatishchev@users.noreply.github.com>
| <ItemGroup> | ||
| <PackageVersion Include="AutoFixture" Version="4.18.1" /> | ||
| <PackageVersion Include="FluentAssertions" Version="8.10.0" /> | ||
| <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="6.0.33" Condition="'$(TargetFramework)' == 'net6.0'" /> |
There was a problem hiding this comment.
@copilot always use the same version of TestHost, 10.0.8
There was a problem hiding this comment.
I validated this request locally: setting Microsoft.AspNetCore.TestHost to 10.0.8 causes restore errors (NU1202) for net6.0, net8.0, and netcoreapp3.1 because 10.0.8 only supports net10.0. I kept the framework-compatible versions, so no commit was made for this comment. No UI changes were made, so there is no UI screenshot.
There was a problem hiding this comment.
@copilot then move Microsoft.AspNetCore.TestHost into a separate item group, each with the corresponding condition (by target framework)
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" /> |
There was a problem hiding this comment.
@copilot always use the same version of DependencyInjection.Abstractions, 10.0.8. Means, get rid of conditions and move the single entry for the package reference to the 1st item group
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
5 similar comments
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
| <ItemGroup> | ||
| <PackageVersion Include="AutoFixture" Version="4.18.1" /> | ||
| <PackageVersion Include="FluentAssertions" Version="8.10.0" /> | ||
| <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="6.0.33" Condition="'$(TargetFramework)' == 'net6.0'" /> |
| <ItemGroup> | ||
| <PackageVersion Include="AutoFixture" Version="4.18.1" /> | ||
| <PackageVersion Include="FluentAssertions" Version="8.10.0" /> | ||
| <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="6.0.33" Condition="'$(TargetFramework)' == 'net6.0'" /> |
There was a problem hiding this comment.
@copilot then move Microsoft.AspNetCore.TestHost into a separate item group, each with the corresponding condition (by target framework)
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
3 similar comments
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@copilot try again to address all prior comments |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
3 similar comments
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@abatishchev Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Description
This PR migrates the repo to NuGet Central Package Management so package versions are defined once and consumed consistently across all projects, and incorporates follow-up review feedback on package organization and versions.
Directory.Packages.propswithManagePackageVersionsCentrally=true.CentralPackageTransitivePinningEnabled=true.PackageVersionitems, including target-framework-specific conditional entries.Version="..."fromPackageReferenceentries across source and test projects.Directory.Build.propsandtests/Directory.Build.propsinto individual project files.Directory.Packages.propsand later removed now-unneeded empty conditional groups.PackageVersionentries alphabetically within eachItemGroupinDirectory.Packages.props.VersionOverrideusage forMicrosoft.NETFramework.ReferenceAssembliesinsrc/JWT/JWT.csprojwith a conditionalPackageVersioninDirectory.Packages.propsfor the corresponding target framework.src/JWT.Extensions.AspNetCore/JWT.Extensions.AspNetCore.csprojinto a single topItemGroupforPackageReferenceitems.Microsoft.Extensions.DependencyInjection.Abstractionspackage reference declarations insrc/JWT.Extensions.DependencyInjection/JWT.Extensions.DependencyInjection.csprojby removing redundant conditionalItemGroups and keeping a single topPackageReferenceitem group.ItemGroups are placed above project referenceItemGroups.ItemGroupformatting across updated projects: no extra blank lines within groups, and a single blank line between groups.tests/JWT.Tests.Net80/JWT.Tests.Net80.csprojso theCompileitem group is below theProjectReferenceitem group.PackageVersiondeclarations inDirectory.Packages.propsinto two item groups: regular packages and test-related packages.tests/JWT.Tests.Common/JWT.Tests.Common.csprojso file include/remove references are below theProjectReferenceitem group.tests/JWT.Extensions.DependencyInjection.Tests/JWT.Extensions.DependencyInjection.Tests.csprojby replacing conditionalMicrosoft.Extensions.DependencyInjectionpackage-reference item groups with a single unconditional item group.tests/JWT.Extensions.AspNetCore.Tests/JWT.Extensions.AspNetCore.Tests.csprojby replacing conditionalMicrosoft.AspNetCore.TestHostpackage-reference item groups with a single unconditional item group.Microsoft.AspNetCore.TestHostcentral package versions into the second (test-related)ItemGroupinDirectory.Packages.propsusing per-target-framework conditions, and removed now-empty framework-specificItemGroups.ItemGroups inDirectory.Packages.propsto the requested order:net35,netstandard2.0,net6.0,net8.0.src/JWT/JWT.csprojpackage version to11.1.0-beta1.System.Text.Jsonto10.0.8.Microsoft.Extensions.DependencyInjectionto the unconditional (first)PackageVersionitem group.Microsoft.Extensions.DependencyInjection.Abstractionsfornetstandard2.0to8.0.2.Microsoft.AspNetCore.TestHostfornet8.0at8.0.8for framework compatibility.PrivateAssets=all.Checklist