fix(tui): inline menu scrolls at the shared 2-rows/notch rate - #78
Merged
Conversation
The inline menu's hand-rolled mouse-wheel handler passed the raw wheel delta straight to `on_scroll` (1 row per notch), while the editor and transcript scrollables move `WHEEL_STEP` (2) rows per notch via `TuiScrollable` — so the inline menu scrolled at half the rate of every other scroll surface. Scale the inline menu's wheel delta by the now-`pub(crate)` `WHEEL_STEP` constant (single source of truth in `editor_element`) so a notch moves the same number of rows everywhere. Updates the bounds test's incidental delta assertion to the corrected rate (its purpose is clamping, unchanged). Addresses the mouse-wheel finding in #5. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gDYSHa4oDvQbfungWwG1h
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the mouse-wheel finding in #5.
The inline menu's hand-rolled wheel handler passed the raw wheel delta to
on_scroll(1 row/notch), while the editor and transcript scrollables moveWHEEL_STEP(2) rows/notch viaTuiScrollable— half the rate everywhere else.Scale by the now-
pub(crate)WHEEL_STEP(single source of truth ineditor_element). Test's incidental delta assertion updated to the corrected rate (its purpose is bounds-clamping, unchanged). inline_menu 24/0.🤖 Generated with Claude Code