fix(tui): transcript clears the active conversation on ClearedConversationsInTerminalView (#4) - #72
Merged
Merged
Conversation
…ationsInTerminalView (#4) TranscriptView::handle_history_event had a `_ => {}` catch-all that ignored BlocklistAIHistoryEvent::ClearedConversationsInTerminalView, so a cleared conversation kept rendering in the transcript. Zap's variant carries no cleared-id list — the `active_conversation_id` *is* the conversation that was cleared (the same reduction `conversation_selection` already uses for this event). Handle it by dropping that conversation's blocks from the transcript, leaving restored/other conversations intact. Fixes the #4 "transcript-clear" real bug: `transcript_clear_event_removes_only_named_conversations` now passes; full transcript_view suite 8/8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gDYSHa4oDvQbfungWwG1h
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real-bug fix for #4.
TranscriptView::handle_history_eventhad a_ => {}catch-all that ignoredBlocklistAIHistoryEvent::ClearedConversationsInTerminalView, so a cleared conversation kept rendering in the transcript.Zap's variant carries no cleared-id list — the
active_conversation_idis the conversation that was cleared (the same reductionconversation_selectionalready applies for this event). Now the transcript drops that conversation's blocks, leaving restored/other conversations intact.Fixes
transcript_view::transcript_clear_event_removes_only_named_conversations. Fulltranscript_viewsuite 8/8.(Part of the #4 real-failure set — the remaining serial failures are separate deeper investigations: focus-pair harness, the diff-pipeline ghost-blocks + write-dispatch bugs, and the footer/zero-state trio.)
🤖 Generated with Claude Code