feat(pane_group): register_remote_repo + preserve remote roots on refresh (5c-2c-i) - #70
Merged
Merged
Conversation
…resh (5c-2c-i) Adds the working_directories side of remote repo-root wiring so a remote (SSH) repository can appear in the code-review panel and get a remote-backed DiffStateModel. - register_remote_repo(pane_group_id, remote_key, terminal_id, ctx): inserts the Remote root into the display roots + repository_roots + directory_to_terminal, and emits RepositoriesChanged / DirectoriesChanged when newly added (mirrors Warp's register_remote_repo). Called from the RemoteRepoNavigated flow in the next increment. - refresh_working_directories_for_pane_group now PRESERVES existing Remote roots across a refresh. The refresh inputs are local CWDs and only recompute Local roots, so remote roots (registered out-of-band) are collected and re-chained into pane_groups / repository_roots / directory_to_terminal instead of being dropped by update_index_set. Behavior-preserving for local-only usage (no Remote keys exist without the RemoteRepoNavigated wiring, which lands in 5c-2c-ii). Verified: warp lib compiles; working_directories 3/0 (+1 new persistence test: a registered remote repo + its terminal mapping survive a local refresh); code_review 76/0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gDYSHa4oDvQbfungWwG1h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
working_directoriesside of remote repo-root wiring so a remote (SSH) repository can appear in the code-review panel and get a remote-backedDiffStateModel.register_remote_repo(pane_group_id, remote_key, terminal_id, ctx)— inserts theRemoteroot into the display roots +repository_roots+directory_to_terminal, and emitsRepositoriesChanged/DirectoriesChangedwhen newly added (mirrors Warp'sregister_remote_repo). Called from theRemoteRepoNavigatedflow in 5c-2c-ii.refreshnow PRESERVES existingRemoteroots. The refresh inputs are local CWDs and only recomputeLocalroots, so remote roots (registered out-of-band) are collected and re-chained intopane_groups/repository_roots/directory_to_terminalinstead of being dropped byupdate_index_set.Behavior-preserving for local-only usage (no
Remotekeys exist without theRemoteRepoNavigatedwiring, which lands next).Verification
warplib compilesworking_directories3/0 (+1 new persistence test: a registered remote repo + its terminal mapping survive a local refresh)code_review76/0🤖 Generated with Claude Code