Skip to content

feat(umd): uglify the umd bundle#134

Open
izifortune wants to merge 4 commits into
jvandemo:masterfrom
izifortune:feature/uglify
Open

feat(umd): uglify the umd bundle#134
izifortune wants to merge 4 commits into
jvandemo:masterfrom
izifortune:feature/uglify

Conversation

@izifortune

Copy link
Copy Markdown
Collaborator

Umd bundle will be minified using the following rollup plugin:
https://github.com/TrySound/rollup-plugin-uglify

@jvandemo

Copy link
Copy Markdown
Owner

@izifortune — Awesome, thank you for your contribution!

Is it possible to generate 2 versions of the UMD bundle?

  • *.umd.js: non-minified UMD bundle
  • *.umd.min.js: minified UMD bundle

That would be similar to how Angular Material generates bundles:
https://github.com/angular/material2-builds/tree/master/bundles

Would you be able to do that? Thanks again! 👍

@izifortune

Copy link
Copy Markdown
Collaborator Author

@jvandemo i had to create another gulp task for this hope you don't mind.

@chrisalexander55

Copy link
Copy Markdown

Curious why this hasn't been merged into current master? Thanks!

@jvandemo

jvandemo commented Aug 14, 2017

Copy link
Copy Markdown
Owner

@izifortune — I'm sorry, I missed your update. I will check it later this week and merge if all works as expected.

Thanks again for your contribution! 👍 /cc @chrisalexander55.

@izifortune

Copy link
Copy Markdown
Collaborator Author

@jvandemo no worries happy to help :)

@fishme

fishme commented Jan 7, 2018

Copy link
Copy Markdown

when is that cool feature available?

@izifortune

Copy link
Copy Markdown
Collaborator Author

Resolved conflicts

@jvandemo

Copy link
Copy Markdown
Owner

@izifortune — Looks like there is still a conflict. Would you be able to resolve it? If not, I can have a look at it as well. Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants