Skip to content

Fix friend search to support full name queries in backend #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juva99 merged 5 commits into from
Jul 25, 2025
Merged

Fix friend search to support full name queries in backend #259

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
159f32b
Initial plan
Copilot Jul 23, 2025
b78be42
Fix friend search to support full name search - add CONCAT to backend…
Copilot Jul 23, 2025
49c5453
Simplify friend search query to use only CONCAT as suggested in review
Copilot Jul 24, 2025
9081c8b
Simplify test file to resolve merge conflicts
Copilot Jul 24, 2025
d2cf3aa
Remove unrelated file changes and test file to resolve merge conflicts
Copilot Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backend/src/users/users.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
import { User } from './users.entity';
import { CreateUserDto } from './dto/create-users.dto';
import { InjectRepository } from '@nestjs/typeorm';
import { Repository, ILike, MoreThan, In } from 'typeorm';
import { Repository, MoreThan, In } from 'typeorm';
import { FriendRelation } from 'src/friends/friends.entity';
import * as crypto from 'crypto';
import * as bcrypt from 'bcrypt';
Expand Down Expand Up @@ -80,12 +80,12 @@ export class UsersService {
}

async findByName(name: string, currentUser: User): Promise<User[]> {
// look up for new friends by first and last name
// look up for new friends by full name
const queryBuilder = this.userRepository.createQueryBuilder('user');

// Search by first name or last name
// Search by full name (concatenated first and last name)
queryBuilder.where(
'(user.firstName ILIKE :name OR user.lastName ILIKE :name)',
"CONCAT(user.firstName, ' ', user.lastName) ILIKE :name",
{ name: `%${name}%` },
);

Expand Down