Add canonical#3008
Draft
blegat wants to merge 1 commit into
Draft
Conversation
odow
reviewed
Jun 5, 2026
| end | ||
|
|
||
| # Workaround: both `is_canonical` and `canonicalize!` would be slow otherwise | ||
| canonical(f::MOI.ScalarNonlinearFunction) = f |
Member
There was a problem hiding this comment.
Ask Claude why they would add this method when there is the one below 😆
Member
Author
There was a problem hiding this comment.
I did it pre-Claude actually 😅 this line is just a temporary hack to isolate things in profiling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #2803
I'm not too convinced by the current approach.
For
canonical, I think we need to implementcanonicalwith a cache that checks that it creates aliases when it sees a second time an alias to the same sub-expression.