Skip to content

fixes flink dist page filtering #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtzero merged 1 commit into from
Feb 10, 2026
Merged

fixes flink dist page filtering #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/utils.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ get_version_folder() {
curl "${curl_opts[*]}" "${dist_folder_url}/" 2>/dev/null | grep -o -E 'href=".+">' | grep -o -E "\".*${semverish}/\"" | tr -d '"/>'
}

get_dist_folder_page() {
local -r dist_folder_url="${1}"
printf '%s' "$(curl "${curl_opts[*]}" "${dist_folder_url}/" 2>/dev/null)"
}

default_filename_extended_pattern() {
local product_name="$1"
local raw_user_version_arg="$2"
Expand Down Expand Up @@ -173,14 +178,20 @@ get_download_url() {
local semver="$2"
local raw_user_version_arg="$3"
local -r product_file="${LIB_DIR}/${PRODUCT_NAME}.sh"
local -r product_libexec_file="${THIS_PLUGIN_LIBEXEC_DIR}/${product_name}.sh"
if [ -f "${product_file}" ]; then
# shellcheck disable=SC1090
. "${product_file}"
fi
local dist_folder_url=""
dist_folder_url="$(get_dist_folder "${product_name}")"
local version_folder=""
version_folder="$(get_version_folder "${product_name}" "${semver}")"
if [ -f "${product_libexec_file}" ]; then
local -r dist_folder_page="$(get_dist_folder_page "${dist_folder_url}")"
version_folder="$("${product_libexec_file}" filter_dist_folder_page "${semver}" "${dist_folder_page}")"
else
version_folder="$(get_version_folder "${product_name}" "${semver}")"
fi
[ -z "${version_folder}" ] && fail "Could not get subversion folder for '${semver}' in '${dist_folder_url}'"
local filename=""
if [[ $(type -t grep_filename) == function ]]; then
Expand Down
10 changes: 10 additions & 0 deletions libexec/flink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ filename_extended_pattern() {
echo "\".*${product_name}-${version}.*(${file_extensions})\""
}

filter_dist_folder_page() {
local -r semverish="${1}"
local -r page="${2}"
printf '%s' "${page}" | grep -o -E 'href=".+">' | grep -o -E "\"flink-${semverish}/\"" | tr -d '"/>'

}

case "$1" in
latest_stable_pattern)
latest_stable_pattern
Expand All @@ -57,6 +64,9 @@ semver_from_user_input)
filename_extended_pattern)
filename_extended_pattern "${2}" "${3}" "${4}" "${5}"
;;
filter_dist_folder_page)
filter_dist_folder_page "${2}" "${3}"
;;
*)
echo "Unknown function $1" >&2
exit 1
Expand Down