Skip to content

Fix CanStub virtual override mismatch causing unit-test compile failure#54

Merged
jsphuebner merged 12 commits into
masterfrom
copilot/fix-unit-test-errors
May 10, 2026
Merged

Fix CanStub virtual override mismatch causing unit-test compile failure#54
jsphuebner merged 12 commits into
masterfrom
copilot/fix-unit-test-errors

Conversation

Copilot AI commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Inspect the current putchar-based printf backend and terminal wrapper
  • Replace the standard putchar dependency with a private libopeninv output hook
  • Update the terminal compatibility implementation to provide the private hook
  • Rebuild affected objects to verify the duplicate declaration issue is gone
  • Run required validation checks and summarize

Copilot AI and others added 2 commits May 10, 2026 17:15
Copilot AI and others added 4 commits May 10, 2026 17:19
@jsphuebner
Adjust CanSdo userspace SDO tests for ProcessUserSpaceSdo flow
f68d4ff 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/784aee6a-4992-4685-a95c-a4c8f365271f

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner
Normalize user-space SDO test helper naming
b128dd8 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/784aee6a-4992-4685-a95c-a4c8f365271f

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner
Align user-space SDO helper field naming in tests
531ca61 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/784aee6a-4992-4685-a95c-a4c8f365271f

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner
Polish userspace SDO test helper style and naming
664a3bd 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/784aee6a-4992-4685-a95c-a4c8f365271f

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
Copilot AI requested a review from jsphuebner May 10, 2026 17:22
Copilot AI and others added 2 commits May 10, 2026 17:37
Copilot AI and others added 3 commits May 10, 2026 17:42
@jsphuebner
Replace standard putchar dependency with private hook
1844b54 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/0b99f87a-a289-4e47-8cd9-8a09141f45db

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner
Use nullptr in terminal printf hook
792332e 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/0b99f87a-a289-4e47-8cd9-8a09141f45db

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner
Widen private printf hook parameter to int
c35776a 
Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/0b99f87a-a289-4e47-8cd9-8a09141f45db

Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com>
@jsphuebner jsphuebner marked this pull request as ready for review May 10, 2026 18:02
@jsphuebner jsphuebner merged commit 78e3f72 into master May 10, 2026
2 checks passed
@jsphuebner jsphuebner deleted the copilot/fix-unit-test-errors branch May 12, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsphuebner jsphuebner Awaiting requested review from jsphuebner

Assignees

@jsphuebner jsphuebner

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsphuebner