feat(collab): per-session server-side editor + renderer fan-out (#2424)#2435
Open
jsmestad wants to merge 1 commit into
Open
feat(collab): per-session server-side editor + renderer fan-out (#2424)#2435jsmestad wants to merge 1 commit into
jsmestad wants to merge 1 commit into
Conversation
Host N independent server-side editor sessions on one node, each with its own Frontend.Manager + Renderer.Server + MingaEditor triad sharing the node-local Buffer.Registry. Default single-session behavior preserved.
- New MingaEditor.Collab.{Names,SessionManager,SessionSupervisor,Cleanup} + Collab orchestration
- DynamicSupervisor of per-session triads; Parser.Manager hoisted to node-shared
- Per-session naming via Registry via-tuples; editor monitors parser and re-subscribes on restart (capped backoff)
- Headless daemon hosts sessions via Runtime.HeadlessSupervisor
- Collision-free editor_session_id; renderer writeback resolves pid/atom/via via GenServer.whereis
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets one Minga node host N independent server-side editor sessions, each with its own
Frontend.Manager+Renderer.Server+MingaEditor, all sharing the node-localBuffer.Registry. Default single-session behavior is preserved. This is the foundation for shared-workspace multi-human collaboration (epic #1100).What changed
MingaEditor.Collabnamespace:Names(per-session via-tuples; the default session falls back to the historical bare module names so existing global lookups keep resolving),SessionSupervisor(per-session triad),SessionManager(DynamicSupervisor + attach/detach lifecycle),Cleanup, andCollab(attach/detach orchestration with rollback).Runtime.SupervisorhoistsParser.Managerto node-shared and replaces the staticMingaEditor.SupervisorwithSessionManager+ a defaultSessionSupervisor.Runtime.HeadlessSupervisorstarts the session-hosting DynamicSupervisor on the headless daemon.GenServer.whereis.Parser.Managerand re-subscribes on restart (capped backoff) — preserving syntax highlighting after a parser crash, now that the parser is no longer in the editor'srest_for_onecascade.editor_session_id.Testing
mix compile --warnings-as-errors,mix format --check-formatted,mix credo --strict: clean.collab/names_test,collab/session_manager_test(incl. two-clients-share-one-buffer acceptance),collab_test(attach/detach),parser_resubscribe_test,runtime/headless_supervisor_test, andeditor_session_idtests.Known limitation (MVP)
The Sidebar/SemanticUI render-trigger registries remain node-shared (documented in
Collab.Cleanup); per-session windows, cursor, mode, and feature-state are fully isolated.Closes #2424. Part of #2422 (tracking) / epic #1100.
🤖 Generated with Claude Code