Implement fiber-segregated data object creation in prepare_all_data#55
Draft
ben-sappey with Copilot wants to merge 4 commits into
Draft
Implement fiber-segregated data object creation in prepare_all_data#55ben-sappey with Copilot wants to merge 4 commits into
ben-sappey with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: ben-sappey <74935396+ben-sappey@users.noreply.github.com>
Co-authored-by: ben-sappey <74935396+ben-sappey@users.noreply.github.com>
Co-authored-by: ben-sappey <74935396+ben-sappey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Segregate science results by fiber in prepare_all_data function
Implement fiber-segregated data object creation in prepare_all_data
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prep_data_objectfunction needed to dynamically identify and segregate science results by fiber number, with science fibers indexed from 0.Changes
Created
prepare_all_data()function that replaces hard-coded fiber enumeration with dynamic detection:np.unique(fiber_list)to identify all discrete science fiber numbers present in the dataMaintained backward compatibility:
prep_data_object()now wrapsprepare_all_data()with deprecation noticeExample Usage
The implementation adapts to any fiber configuration without assuming exactly 4 fibers are present.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
simbad.cds.unistra.fr/usr/bin/python python -m pytest breads/tests/ -v(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Created from VS Code via the GitHub Pull Request extension.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.