Add support for error code#145
Open
lasantosr wants to merge 2 commits into
Open
Conversation
Closed
Contributor
Author
|
@jprochazk is there something missing to merge this PR? |
Contributor
|
Since compact_str allow you to put |
ghost
reviewed
Sep 2, 2025
| self.message.as_ref() | ||
| } | ||
|
|
||
| pub fn set_code(&mut self, code: impl Into<Cow<'static, str>>) { |
There was a problem hiding this comment.
Is it even necessary to allocate the string on the heap? Why can't we just store &'static str everywhere?
If users need the heap-allocated codes, they should be able to make a wrapper for garde::Error with their own implementation of .set_code(...).
Error code (also known as reason) is usually a part of the API Contract and in Google all reasons are usually constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would close #105