Adds support for WebP - #3
Open
koalalorenzo wants to merge 10 commits into
Open
Conversation
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
Signed-off-by: Lorenzo Setale <lorenzo@setale.me>
updates dependencies to prevent out-of-bound reads See merge request koalalorenzo/gomeme!1
Author
|
@jpoz I hope you can review this PR some times 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am using your module in my Twitch Meme Bot generator (I wrote a blog post about it here). As I needed to add smaller image formats I added support to WebP. I added also some changes from @peterebden
Sadly this fork adds libraries that forces building only using GCC as I was not able to find a native go WebP decoder and encoder. This support only WebP and not Animated WebP. It would be nice to contribute back on that too if I have time.
Feel free to suggest changes, update it or discard it entirely if you want! Thank you so much @jpoz for this go module, I had a lot of fun generating images! ❤️