feat(webapi): fetch artist discography via pathfinder GraphQL - #746
Merged
Conversation
Contributor
Author
|
We should maybe consider to set some kind of limit for loading appears-on, as the list can be long for bigger artists. Or maybe some kind of load-more-option that the user can trigger. |
jacksongoode
approved these changes
Jul 19, 2026
jacksongoode
left a comment
jacksongoode
left a comment
Collaborator
There was a problem hiding this comment.
Also looks good. I suggest we do a cleanup pass once we get things working 👍
Collaborator
|
@prefixFelix Just a few changes to make sure CI/CD pass. |
Contributor
Author
|
Collaborator
|
Ok could you rebase now, so we can check the checks? |
12 tasks
Collaborator
|
I'll rebase & rerun the builds. |
jacksongoode
force-pushed
the
pr2-artist-discography
branch
from
August 17, 2026 03:20
24b06be to
b081f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #744, split out for review.
Artist albums/singles/compilations/appears-on now come from the pathfinder discography operations on
api-partner.spotify.comviapartner_authinstead of the REST endpoint, which the API changes broke. Each section is a separate paginated GraphQL query. Also drops the old release-year heuristic that, since the API now returns that section directly.