fix: resolve #100 — crashing with "Symbol not found: ____chkstk_darwin" on macOS 10.13 - #728
Open
chinhkrb113 wants to merge 2 commits into
Conversation
…tk_darwin" on macOS 10.13 Fixes jpochyla#100 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
…tk_darwin" on macOS 10.13 Fixes jpochyla#100 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To ensure consistent behavior across CI and local builds, a
.cargo/config.tomlfile can set theMACOSX_DEPLOYMENT_TARGETenvironment variable for the build process. This prevents developers from accidentally producing binaries that require a newer macOS than intended, regardless of where the build happensFixes #100
Changes
.cargo/config.toml(new)tests/cargo_config_test.rs(new)Why
.cargo/config.toml: To ensure consistent behavior across CI and local builds, a.cargo/config.tomlfile can set theMACOSX_DEPLOYMENT_TARGETenvironment variable for the build process. This prevents developers from accidentally producing binaries that require a newer macOS than intended, regardless of where the build happens.