fix: resolve #365 — AppImage build fails - #727
Open
chinhkrb113 wants to merge 2 commits into
Open
Conversation
Fixes jpochyla#365 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Collaborator
|
@chinhkrb113 Were you able to build and run the AppImage that resulted from this run? |
jacksongoode
approved these changes
Jun 26, 2026
jacksongoode
left a comment
jacksongoode
left a comment
Collaborator
There was a problem hiding this comment.
This looks good but let's confirm this indeed builds & runs?
Author
|
@jacksongoode I pushed an update that restores the AppImage workflow and adds a smoke test for the generated AppImage. The changes now:
I also verified the local checks: |
Collaborator
|
Do we need this "Smoke Test AppImage" I think cleaning up this PR so its exclusively only the minimal changes necessary to get the build working would be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pkg2appimage-ingredients.yml file defines how the AppImage is assembled. If the project switches from pkg2appimage to linuxdeploy, this file may no longer be needed. If keeping pkg2appimage, the ingredients file may need updates to reference correct package sources or binary paths
Fixes #365
Changes
.pkg/APPIMAGE/pkg2appimage-ingredients.ymlWhy
.pkg/APPIMAGE/pkg2appimage-ingredients.yml: The pkg2appimage-ingredients.yml file defines how the AppImage is assembled. If the project switches from pkg2appimage to linuxdeploy, this file may no longer be needed. If keeping pkg2appimage, the ingredients file may need updates to reference correct package sources or binary paths.