Skip to content

Subtitle bug and cleanup - #22

Open
colonelchlorine wants to merge 6 commits into
jparnell8839:masterfrom
colonelchlorine:subtitle-bug-and-cleanup
Open

Subtitle bug and cleanup#22
colonelchlorine wants to merge 6 commits into
jparnell8839:masterfrom
colonelchlorine:subtitle-bug-and-cleanup

Conversation

@colonelchlorine

Copy link
Copy Markdown

Most changes in MyApplicationContext.AoT:

  • Updated string check code that used to throw exceptions if length of window < 14. Now just check string EndsWith.
  • Methods.GetWindowTitle async. Identifies it doesn't complete instantly.
  • Refactor / update code

Haven't worked with forms very much in the past, but I wonder if we can look at converting to .NET Core framework. Might need to look at UWP rather than winforms. Not sure

Tabs, fix modifiers, unused variables, switched to just var
Didn't realize that Methods.GetWindowTitle pauses / holds app
until it's found something.
At least it's clear it doesn't return immediately
@colonelchlorine

Copy link
Copy Markdown
Author

@jparnell8839 let me know what you think. Looks like no ones assign pull request

Update comment text.
@colonelchlorine

Copy link
Copy Markdown
Author

@jparnell8839 Any updates?

@colonelchlorine

Copy link
Copy Markdown
Author

Is this repo still alive?

@krystian3w

Copy link
Copy Markdown

IMO nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants