fixed an issue whereby files encoded with UTF8-BOM would cause imports to be skipped#122
Open
rikrak wants to merge 1 commit intojoneff:developfrom
Open
fixed an issue whereby files encoded with UTF8-BOM would cause imports to be skipped#122rikrak wants to merge 1 commit intojoneff:developfrom
rikrak wants to merge 1 commit intojoneff:developfrom
Conversation
…mports to be ignored joneff#121
Author
|
Oh, also. Had to force push my changes to GitHub as husky(?) was grumbling about CRLF in some of the .ts files. I hadn't made any changes in these files, so figured it was a pre-existing issue, or it was environmental :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #121
When importing a file that is encoded as UTF8-BOM, the leading non-printing character is preserved in the buffer and written to the output. This causes subsequent SASS builds to fail. In addition, if the BOM encoded file has an
@importon the first line it is missed by baka as it doesn't recognise<ZWNBSP>@import 'blah';I've fixed this in rather a blunt way by using a find/replace. There may well be a better way of doing this with fs, but I'm not familiar with the world of js libs to know of a better way :-/