Harden evaluator evidence lifecycle and promotion workflow - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CodexRuntimelifecycle for target, rubric judge, pairwise judge, and calibration invocationsWhy
The evaluator's scientific claim depends on holding the runner lifecycle constant while changing only the treatment. Target and judge paths had accumulated separate process and workspace behavior, leaving room for isolation drift and ancestor-project instruction leakage. Promotion intent was also not represented strongly enough in the executable contract.
This change concentrates the complete Codex invocation lifecycle behind one interface and makes the distinction between development evidence and promotion evidence explicit.
Impact
Operators get:
The CLI and retained report workflow remain compatible. This does not claim that a visible development suite is an independent promotion holdout, and it does not treat a configured executable as an untrusted sandboxed process.
Validation
python3 -m unittest discover -s tests -p 'test_*.py'— 47 tests passedruff check skills/skill-eval-loop/scripts/skill_eval_loop.py tests/test_skill_eval_loop.py— passedpython3 -m py_compile skills/skill-eval-loop/scripts/skill_eval_loop.py— passedskills/skill-eval-loop/scripts/healthcheck.sh— validgit diff --check— passed