This repository was archived by the owner on Sep 14, 2025. It is now read-only.
Modify stb.getUrl to retun fast, already "deep" url, or to discover and return a deep one. #7
Open
peshovec wants to merge 1 commit into
Open
Modify stb.getUrl to retun fast, already "deep" url, or to discover and return a deep one. #7peshovec wants to merge 1 commit into
peshovec wants to merge 1 commit into
Conversation
… with already discovered one. This allow to use stb.getUrl without performance penalty in any case. And allow just to invoke it every time, before passing "discovered portal url" to other function - for example to validate mac addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow to invoke stb.getUrl anytime before passing url (which has to be the deep one) to other function.
Potential use case is when adding new portal to check (deep url is needed) the validity of macs.