Add transcript annotation UI - #308
Merged
Merged
Conversation
6 tasks
Owner
Author
Review RecordTarget reviewed: Reproduce diff: git diff --find-renames 1b5455018e3bbcaa9f0cd326cfb8313ba58da10c..bdda102d8ddbbd9757c85beee561b53a7eeecc35Panel design:
Accepted findings fixed:
Rejected/follow-up findings:
Final reviewer status:
Validation:
Note: one intermediate full e2e attempt hit an unrelated existing dashboard-search scroll timeout; the failed test passed on focused rerun, and the subsequent full |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #303.
Summary
Validation
make generate-checkmake fmt-checkmake testmake lintmake buildnpm run test:frontendnpm run test:e2enpm run test:a11ygit diff --checkmake install-local INSTALL_DIR="$HOME/.local/bin", restarted in tmux, and verified withcurl -fsS http://localhost:4600/ >/dev/null.QA Artifacts
test-results/annotations/session-annotation-desktop.pngtest-results/annotations/event-annotation-drawer.pngtest-results/annotations/session-annotation-mobile.pngtest-results/annotations/review-server-dashboard.pngNotes