You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For det første: Tak for dette utroligt nyttige tip!
What problem does this solve?
Allows users to track any extras that comes with their seat.
For me as a tall person, this is primarily useful to track how often I managed to get a (free) extra legroom and/or emergency exit seat.
What does this MR do?
Adds a new field seatExtras, defaulting to []
Multiple tags can be selected at once
Adds a PieChart for those
Extends tests accordingly
Screenshots
Feedback needed
The current tags are a suggestion. Let me know if one is missing or should be removed from the list.
AI-Disclaimer: AI assisted in this MR. I have manually reviewed and verified suggestions where applicable.
Note
Add seat extras field to flight seat records with statistics and form support
Adds a seatExtras string array field to the seat table via a new Prisma migration, with a default of [].
Extends the seat information form in SeatInformation.svelte with toggle buttons for selecting multiple extras per seat.
Adds a 'Seat Extras' pie chart to the statistics modal and implements the full aggregation and filter-matching logic in aggregations.ts.
Updates all import processors (AITA, ByAir, Flighty, FR24, JetLog, OpenFlights, TripIt, etc.) to include seatExtras: [] on imported seats.
can we also add "empty row" or "extra seat" to this? some flights offer, for an extra fee, a guaranteed seat, meaning that you can either have an empty seat next to you (I guess technically you could do this buy clicking the "add seat" option today), or if it's you and another person, an entire row to yourself.
Thanks for the contribution! I ended up solving this more generally in #679 by adding per-passenger custom fields, including multi-select fields. That covers seat extras without baking a fixed list into AirTrail, so I'm closing this in favor of that approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For det første: Tak for dette utroligt nyttige tip!
What problem does this solve?
Allows users to track any extras that comes with their seat.
For me as a tall person, this is primarily useful to track how often I managed to get a (free) extra legroom and/or emergency exit seat.
What does this MR do?
seatExtras, defaulting to[]Screenshots
Feedback needed
AI-Disclaimer: AI assisted in this MR. I have manually reviewed and verified suggestions where applicable.
Note
Add seat extras field to flight seat records with statistics and form support
seatExtrasstring array field to theseattable via a new Prisma migration, with a default of[].seatExtras: []on imported seats.Macroscope summarized aad157e.