Fix/macos py2app libsharpyuv (#587) - #2
Merged
Conversation
* Bundle libsharpyuv for macOS py2app build py2app doesn't rewrite @rpath load commands, so libwebp's dependency on libsharpyuv (split out since webp 1.3) goes missing from the app bundle and PIL fails to import at launch. Bundle and patch it explicitly, same as the freecell-solver lib. * Re-sign macOS bundle after post-py2app dylib patching install_name_tool invalidates py2app's ad-hoc signature, so a bundle patched after signing (e.g. the libsharpyuv fix, or the existing fc-solve rpath fix) gets silently SIGKILLed by macOS on launch. Verified locally: without this, the fixed app dies with no output at all: the patched dylib breaks the code signature seal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py2app doesn't rewrite @rpath load commands, so libwebp's dependency on libsharpyuv (split out since webp 1.3) goes missing from the app bundle and PIL fails to import at launch. Bundle and patch it explicitly, same as the freecell-solver lib.
install_name_tool invalidates py2app's ad-hoc signature, so a bundle patched after signing (e.g. the libsharpyuv fix, or the existing fc-solve rpath fix) gets silently SIGKILLed by macOS on launch. Verified locally: without this, the fixed app dies with no output at all: the patched dylib breaks the code signature seal.