Skip to content

fix(pr-followup): PR #716 comment 3330228890 — **<sub><sub>![P2 Badge](https://img.shields.io/badge…#718

Merged
joeharris76 merged 2 commits into
developfrom
fix/pr-review-followups-20260531-round2
May 31, 2026
Merged

fix(pr-followup): PR #716 comment 3330228890 — **<sub><sub>![P2 Badge](https://img.shields.io/badge…#718
joeharris76 merged 2 commits into
developfrom
fix/pr-review-followups-20260531-round2

Conversation

@joeharris76
Copy link
Copy Markdown
Owner

Disposition: fixed
Source: #716 (comment)
Path: scripts/generate_changelog_entry.py

@joeharris76 joeharris76 enabled auto-merge (squash) May 31, 2026 13:52
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc82b57588

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +275 to +277
if any(
_tree_entry_at(source, commit_hash, path) != _tree_entry_at(source, since_ref, path)
for path in relevant_paths
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude squashed intermediate same-file commits

When a previous squash release contained multiple conventional commits touching the same file, and the next patch also edits that file, this comparison can still re-include older released subjects. For example, if develop had feat changing f.txt to A, then fix changing it to A+B, main squash-merged A+B, and the new patch changes f.txt to A+B+C, the first old commit's tree entry (A) differs from main (A+B), so it is incorrectly selected for the new changelog even though it was already released.

Useful? React with 👍 / 👎.

@joeharris76 joeharris76 merged commit 1406639 into develop May 31, 2026
13 checks passed
@joeharris76 joeharris76 deleted the fix/pr-review-followups-20260531-round2 branch May 31, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant