Add headers support - #35
Conversation
|
Hmm... the more I think about this, the more I lean towards just supporting the Edit: I'd gladly do the legwork for this. |
|
This is a feature that we would like also. Either directly via headers flag or via |
|
@samhagan if you want i have some time over the weekend, i could whip up a PR for using |
|
@StevenLangbroek one thing to consider, not related to the headers, is other configuration this package may need. For example, we're using custom scalar types that by default result in |
I'm switching from using a GraphQL based service to my own CMS installation, and its security requirements are different, so I needed custom headers :). Some notes on this PR:
--helpfor README.md is differently sorted than yours... No idea why, wasn't sure whether you'd like to maintain the old order...Furthermore, I think you're reaching the point where it might be good to add some integration-level testing (mocking out the network / fs), and some convention etc... Would you like me to add eslint, editorconfig, prettier and basic set up for more extensive testing?