chore(release): fix bump-version.sh commit-message hint + untrack accidental worktree gitlinks#135
Merged
Merged
Conversation
…nore The v0.10.0 release commit (937f8b4) captured 8 worktree directories as gitlinks (mode 160000) because `scripts/bump-version.sh` ran `git add -A` while the per-phase worktrees were live in .claude/worktrees/. They aren't real submodules — no `.gitmodules`, no remote — just orphan gitlink references to commits on the now-deleted `worktree-phase-*` branches. Removing the gitlink entries from the index now that the worktrees have been cleaned up. Adding .claude/worktrees/ to .gitignore so the next round of phase worktrees doesn't repeat the issue. Not rewriting v0.10.0's history — the release tag is already published, and the orphan gitlinks there don't break anything for consumers (no .gitmodules → git won't try to fetch them on clone). Forward state is clean from this commit on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…essage Followup from the v0.10.0 release misfire. `scripts/bump-version.sh` correctly bumps all 11 manifests but doesn't tell the user what to do next, so a freshly-run script + a manual `git commit -m "chore(release): bump to <V>"` is a natural shape that silently skips the publish pipeline (the release workflow's detect regex is ^release: v[0-9]+\.[0-9]+\.[0-9]+$ and rejects everything else). The release-pr.yml workflow path (the "happy" path) already emits the right commit message; this fix is for the manual-fallback path that the v0.10.0 release used. - Print the exact `git commit -am 'release: v<V>'` line. - Print the recovery command (`gh workflow run release.yml -f version=<V>`) for cases when the wrong commit message has already been pushed. Also includes the .claude/worktrees/ gitlink cleanup that was an unrelated side-effect of the v0.10.0 bump commit picking up live worktree directories as gitlinks (mode 160000) via `git add -A`. Adds .claude/worktrees/ to .gitignore so the next round of phase worktrees doesn't repeat the issue, and untracks the 8 orphan gitlink entries. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
joaoh82
added a commit
that referenced
this pull request
May 12, 2026
…138) `jetli/wasm-pack-action` and wasm-pack's curl-installer both let wasm-pack pick whatever binaryen its internal cache happens to hold. When that copy predates multi-table WASM support, wasm-opt rejects rustc output with "Only 1 table definition allowed in MVP" — a flake whose hit/miss depended on runner image cache state (first surfaced on PR #135; rerun passed). Pin binaryen to version_122 in both the ci.yml `wasm-build` and release.yml `publish-wasm` jobs by downloading the official tarball before wasm-pack runs and prepending it to PATH. wasm-pack auto-detects wasm-opt on PATH, so no further wiring needed. Bump procedure documented in docs/release-plan.md so future-me knows to update both workflows in lockstep. Verified locally on darwin-arm64: `wasm-pack build --target web --release` reports `[INFO]: found wasm-opt at ".../binaryen-version_122/bin/wasm-opt"` and builds a 2.14 MiB bundle (in line with prior sizes). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two release-pipeline hygiene fixes uncovered by the v0.10.0 release misfire (the publish pipeline didn't run on the
chore(release): bump to 0.10.0commit; recovered viagh workflow run release.yml -f version=0.10.0).scripts/bump-version.shnow tells you exactly what commit message to use. The release workflow's detect job (.github/workflows/release.yml) requires the regex^release: v[0-9]+\.[0-9]+\.[0-9]+$— anything else silently skips publish. The script previously printed only `git diff` / `git checkout .` next-steps, so a manual `git commit -m "chore(release): bump to "` was the natural-but-wrong path..gitignoreignores.claude/worktrees/and the index untracks the 8 orphan gitlink entries that the v0.10.0 bump commit (937f8b4) captured.git add -Afrom main while phase worktrees were live under.claude/worktrees/<name>/picked them up as gitlinks (mode 160000) — no.gitmodules, so they're orphan references to commits on the now-deletedworktree-phase-*branches.Both are pure infrastructure / repo hygiene; zero application or engine impact.
Why now
The v0.10.0 release shipped (or rather: was dispatched via the workflow's
workflow_dispatchfallback after the auto-trigger skipped). These fixes prevent the same trap on v0.10.1 / v0.11.0 / etc.Changes
scripts/bump-version.shThe new tail:
.gitignore+ index cleanupIndex untracks (no working-copy effect, the worktrees were already removed manually):
Not rewriting the v0.10.0 tag — orphan gitlinks at that commit don't break anything for consumers (no
.gitmodules→ git won't try to fetch them on clone, just emits a noisy warning duringactions/checkout).Cross-checks done
release-plan.mdalready documents therelease: v<V>convention (line 197) — docs are correct, the bump-script was the lone weak link.release-pr.yml(line 113) emitsgit commit -m "release: v${{ inputs.version }}"— the happy path workflow path is fine; this fix only matters for the manual-fallback path the v0.10.0 release used.Test plan
bash -n scripts/bump-version.sh— syntax check (no functional change, just trailingechos).🤖 Generated with Claude Code