Skip to content

Added EventEmitter support - #4

Open
galenwp wants to merge 4 commits into
jmlewis:masterfrom
galenwp:master
Open

Added EventEmitter support#4
galenwp wants to merge 4 commits into
jmlewis:masterfrom
galenwp:master

Conversation

@galenwp

@galenwp galenwp commented Dec 29, 2012

Copy link
Copy Markdown

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

@jmlewis

jmlewis commented Dec 29, 2012

Copy link
Copy Markdown
Owner

Did you merge the latest collate changes? I see this pull request as not able to be automatically merged.

On Dec 28, 2012, at 11:54 PM, Galen Wolfe-Pauly notifications@github.com wrote:

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

You can merge this Pull Request by running:

git pull https://github.com/galenwp/collate master
Or view, comment on, or merge it at:

#4

Commit Summary

• Beta EventEmitter support
File Changes

• M lib/collate.js (33)
• M src/collate.coffee (14)
Patch Links

https://github.com/jmlewis/collate/pull/4.patch
https://github.com/jmlewis/collate/pull/4.diff

Reply to this email directly or view it on GitHub.

@galenwp

galenwp commented Dec 29, 2012

Copy link
Copy Markdown
Author

Whoops, will do and re send

On Dec 29, 2012, at 12:17 PM, Joshua Lewis wrote:

Did you merge the latest collate changes? I see this pull request as not able to be automatically merged.

Josh

On Dec 28, 2012, at 11:54 PM, Galen Wolfe-Pauly notifications@github.com wrote:

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

You can merge this Pull Request by running:

git pull https://github.com/galenwp/collate master
Or view, comment on, or merge it at:

#4

Commit Summary

• Beta EventEmitter support
File Changes

• M lib/collate.js (33)
• M src/collate.coffee (14)
Patch Links

https://github.com/jmlewis/collate/pull/4.patch
https://github.com/jmlewis/collate/pull/4.diff

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@galenwp

galenwp commented Dec 29, 2012

Copy link
Copy Markdown
Author

Events are only emitted in verbose mode. Is that the best way to do it? If being used from the CLI it probably doesn't matter if the events are being emitted, and the emit calls could happen whether in verbose mode or not.

Thoughts?

@jmlewis

jmlewis commented Dec 29, 2012

Copy link
Copy Markdown
Owner

I think it should always emit events since you can choose whether to listen to them.

On Dec 29, 2012, at 4:27 PM, Galen Wolfe-Pauly notifications@github.com wrote:

Events are only emitted in verbose mode. Is that the best way to do it? If being used from the CLI it probably doesn't matter if the events are being emitted, and the emit calls could happen whether in verbose mode or not.

Thoughts?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants