You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to_number implementation fails to cast arguments of the standard type json.Number.
All numbers are converted to json.Number (a mere string) when UseNumber has been set on the json Decoder.
More context on the issue (and why the fix):
We sometimes need to set json.UseNumber on a json decoder. However, when we do so, go-jmespath fails to decode JSON numbers because jpfToNumber doesn't handle it.
The PR fixes that
Is there a specific compliance test that would show the failure before this PR gets merged ?
Hi @springcomp yes there should be a test.
I'll look into it, should be relatively easy, i'd just need to look at the code a bit since I've opened the PR it was 1.5 year ago.
Thanks for doing this btw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_numberimplementation fails to cast arguments of the standard typejson.Number.All numbers are converted to json.Number (a mere string) when
UseNumberhas been set on the json Decoder.