fix(codex): reconcile stale Responses WebSocket profiles - #2006
Draft
Jonesxq wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When Responses WebSocket is disabled, reconcile already-managed Codex profiles whose persisted capability metadata is stale. The repair updates both the provider capability in
config.tomland every model'sprefer_websocketsvalue in the configured model catalog.Why
Issue #1984 reports that new Codex conversations still retry WebSocket connections five times until the user manually edits
config.toml. The routing toggle previously rewrote profiles only when the collection setting changed, so stale profiles survived restarts and repeated saves.Validation
cargo test --manifest-path src-tauri/Cargo.toml --lib codex_local_access::tests -- --nocapture(232 passed)cargo test --manifest-path src-tauri/Cargo.toml stale_profile_websocket_capabilities_trigger_reconciliation -- --nocapture(passed)go test ./... -run 'TestCodexClientModelsResponse|TestResponsesWebsocketRoute' -count=1insidecars/cockpit-cliproxy(passed)git diff --check(passed)node_modules.